Skip to content

NetworkCloud 2022-12-12 API - aaz test recordings added for all resources #6245

Merged
kairu-ms merged 11 commits intoAzure:mainfrom
priyamshet:priyashet/networkCloudAutomation
Jun 15, 2023
Merged

NetworkCloud 2022-12-12 API - aaz test recordings added for all resources #6245
kairu-ms merged 11 commits intoAzure:mainfrom
priyamshet:priyashet/networkCloudAutomation

Conversation

@priyamshet
Copy link
Member

@priyamshet priyamshet commented May 1, 2023 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command


az networkcloud -h

Group
    az networkcloud : Manage Network Cloud resources.
        This command group is experimental and under development. Reference and support levels:
        https://aka.ms/CLI_refstatus
Subgroups:
    baremetalmachine     : Manage bare metal machine.
    cloudservicesnetwork : Manage cloud services network.
    cluster              : Manage cluster.
    clustermanager       : Manage cluster manager.
    defaultcninetwork    : Manage default CNI network.
    hybridakscluster     : Manage additional details of Hybrid AKS provisioned cluster.
    l2network            : Manage layer 2 (l2) network.
    l3network            : Manage layer 3 (l3) network.
    rack                 : Manage rack.
    racksku              : Manage rack SKU.
    storageappliance     : Manage storage appliance.
    trunkednetwork       : Manage trunked network.
    virtualmachine       : Manage virtual machine.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 1, 2023

Hi @priyamshet,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@yonzhan
Copy link
Collaborator

yonzhan commented May 1, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@priyamshet priyamshet force-pushed the priyashet/networkCloudAutomation branch 2 times, most recently from e72808d to 6fa35ca Compare May 1, 2023 23:09
@priyamshet
Copy link
Member Author

priyamshet commented May 1, 2023 •
edited
Loading

This PR has been updated to include aaz recordings for all test resources.

@priyamshet priyamshet force-pushed the priyashet/networkCloudAutomation branch from 6fa35ca to 8444bb3 Compare May 1, 2023 23:46
@yonzhan yonzhan requested a review from necusjz May 2, 2023 00:25
@yonzhan yonzhan requested a review from jsntcy May 2, 2023 00:25
@priyamshet priyamshet changed the title NetworkCloud tests added for L3network - Test PR to validate scenario tests NetworkCloud tests added for L3network - Test PR to validate scenario tests - Do not merge May 2, 2023
@priyamshet priyamshet force-pushed the priyashet/networkCloudAutomation branch from 8444bb3 to a431e22 Compare May 2, 2023 13:18
@priyamshet priyamshet changed the title NetworkCloud tests added for L3network - Test PR to validate scenario tests - Do not merge NetworkCloud 2022-12-12 API - aaz test recordings added for all API May 31, 2023
@priyamshet priyamshet marked this pull request as ready for review May 31, 2023 21:07
@priyamshet priyamshet changed the title NetworkCloud 2022-12-12 API - aaz test recordings added for all API NetworkCloud 2022-12-12 API - aaz test recordings added for all resources Jun 1, 2023
@mbashtovaya mbashtovaya requested a review from kairu-ms June 5, 2023 13:22
kairu-ms
kairu-ms reviewed Jun 6, 2023
View reviewed changes
src/networkcloud/azext_networkcloud/operations/cluster/metricsconfiguration/common.py Outdated
Comment on lines 19 to 30
def _build_arguments_schema(cls, args_schema):
# deregister the Cluster metrics configuration name argument which users
# should not interact with
args_schema.metrics_configuration_name._registered = False
args_schema.metrics_configuration_name._required = False
return args_schema

@classmethod
def pre_operations(cls, args):
''' "default" is the default name for the metrics configuration name '''
args.metrics_configuration_name = "default"
return args
Copy link
Contributor

@kairu-ms kairu-ms Jun 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@necusjz, I think we can add additional property called 'const' in aaz, for some required arguments which are not allowed to input a value. Or we can improve the logic of 'default' in aaz runtime, which can assign default value when it's not registered.

kairu-ms
kairu-ms reviewed Jun 6, 2023
View reviewed changes
kairu-ms
kairu-ms reviewed Jun 6, 2023
View reviewed changes
@mbashtovaya mbashtovaya mentioned this pull request Jun 8, 2023
Merged
@mbashtovaya
Copy link
Member

mbashtovaya commented Jun 8, 2023

@kairu-ms please see the PR to update command models as suggested above: Azure/aaz#206

@kairu-ms
Copy link
Contributor

kairu-ms commented Jun 9, 2023

@kairu-ms please see the PR to update command models as suggested above: Azure/aaz#206

LGTM. It's merged.

@priyamshet
Merge branch 'priyashet/networkCloudAutomation' of github.com:priyams…
8517f2f 
…het/azure-cli-extensions into priyashet/networkCloudAutomation
@priyamshet
Merge branch 'priyashet/networkCloudAutomation' of github.com:priyams…
02625dc 
…het/azure-cli-extensions into priyashet/networkCloudAutomation
@priyamshet
Merge branch 'priyashet/networkCloudAutomation' of github.com:priyams…
eb8b5fb 
…het/azure-cli-extensions into priyashet/networkCloudAutomation
@priyamshet
Merge branch 'priyashet/networkCloudAutomation' of github.com:priyams…
d1d0c0f 
…het/azure-cli-extensions into priyashet/networkCloudAutomation
@priyamshet priyamshet requested a review from kairu-ms June 12, 2023 17:05
@mbashtovaya
Copy link
Member

mbashtovaya commented Jun 13, 2023

@kairu-ms please check our updates as per your suggestions

kairu-ms
kairu-ms reviewed Jun 14, 2023
View reviewed changes
@kairu-ms
Copy link
Contributor

kairu-ms commented Jun 14, 2023 •
edited
Loading

@kairu-ms please check our updates as per your suggestions

Thanks for the update. Added one comment. The rest LGTM.

@priyamshet
Copy link
Member Author

priyamshet commented Jun 14, 2023

@kairu-ms thanks for the re-review, the comments have been addressed.

@priyamshet priyamshet requested a review from kairu-ms June 14, 2023 18:44
@kairu-ms
Copy link
Contributor

kairu-ms commented Jun 15, 2023

@kairu-ms thanks for the re-review, the comments have been addressed.

PR is approved. Ping me when you need to merge and release it.

@mbashtovaya
Copy link
Member

mbashtovaya commented Jun 15, 2023

@kairu-ms thanks for the re-review, the comments have been addressed.

PR is approved. Ping me when you need to merge and release it.

We’d like to merge it. Thanks for you help. @kairu-ms

@kairu-ms kairu-ms merged commit aea8136 into Azure:main Jun 15, 2023
@azclibot
Copy link
Collaborator

azclibot commented Jun 15, 2023

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=64666&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@necusjz necusjz Awaiting requested review from necusjz

@jsntcy jsntcy Awaiting requested review from jsntcy

+1 more reviewer

@mbashtovaya mbashtovaya mbashtovaya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kairu-ms kairu-ms

Labels

None yet

Projects

None yet

Milestone

May 2023 (2023-05-23) - For Build

Development

Successfully merging this pull request may close these issues.

5 participants

@priyamshet @yonzhan @mbashtovaya @kairu-ms @azclibot